Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeiss ZVI: ignore invalid plane coordinates #544

Merged
merged 1 commit into from
Jun 14, 2013

Conversation

melissalinkert
Copy link
Member

If the parsed coordinates do not account for all of the images, then we
need to ignore them. Otherwise, openBytes with different values of 'no'
may open the same image.

See http://www.openmicroscopy.org/community/posting.php?f=13&t=5130#pr10246

If the parsed coordinates do not account for all of the images, then we
need to ignore them.  Otherwise, openBytes with different values of 'no'
may open the same image.

See http://www.openmicroscopy.org/community/posting.php?f=13&t=5130#pr10246
@melissalinkert
Copy link
Member Author

The files mentioned in the forum post have been added to data_repo/from_skyking/zeiss-zvi/oli/

--test zeiss-zvi

@mtbc
Copy link
Member

mtbc commented Jun 6, 2013

Against ome/data_repo/from_skyking/zeiss-zvi/oli/ I get,

   [testng] Total files: 6
   ...
   [testng] LOCI software test suite
   [testng] Total tests run: 276, Failures: 0, Skips: 184

and the regular test suite passes happily.

@mtbc
Copy link
Member

mtbc commented Jun 6, 2013

It's okay with me if this is merged.

@joshmoore
Copy link
Member

All develop jobs still green. Merging.

joshmoore added a commit that referenced this pull request Jun 14, 2013
Zeiss ZVI: ignore invalid plane coordinates
@joshmoore joshmoore merged commit ef3c624 into ome:develop Jun 14, 2013
@melissalinkert melissalinkert deleted the zvi-coordinates branch November 6, 2013 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants