Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Minio dependency with a service #39

Merged
merged 7 commits into from Feb 6, 2019

Conversation

Projects
None yet
4 participants
@manics
Copy link
Member

commented Feb 4, 2019

Replaces the Minio client dependency with an optional service. See https://trello.com/c/UJGyYSrg/129-s3-and-imagej

Testing: check you can run bioformats without Minio.

manics added some commits Jan 31, 2019

@sbesson sbesson added this to the 6.0.0 milestone Feb 4, 2019

@melissalinkert
Copy link
Member

left a comment

Minor comments aside, I don't see any obvious issues reading through this. Leaving @sbesson to conduct functional tests as discussed.

manics added some commits Feb 5, 2019

@manics

This comment has been minimized.

Copy link
Member Author

commented Feb 5, 2019

@melissalinkert @mtbc Thanks for reviewing, I've updated this PR

@sbesson

This comment has been minimized.

Copy link
Member

commented Feb 5, 2019

Initial testing based on the state of 3a59777 looked good. In a Fiji distribution with indivually replaced JARs including the new ome-common, I was able to open individual files of various formats without issue.

As additional commits have been pushed since, in #39 (commits), re-testing will have to be performed with a new build including the last changes. Looks promising.

@sbesson

sbesson approved these changes Feb 6, 2019

Copy link
Member

left a comment

Retested using a local Fiji application with manually modified JARs including ome-common-6.0.0-SNAPSHOT with this PR included

screen shot 2019-02-06 at 13 14 41

Opening images from various formats using the Bio-Formats importer works as expected i.e. the error message reported in ome/bio-formats-fiji#19 (comment) is no longer thrown immediately after selecting the file and both metadata and pixel data are read as expected.

I have not tested the workflow with minio included pointing to a remote location on s3 but from a functional perspective, the addition of the service is sufficient to preserve the current statu quo in terms of deployment of the Bio-Formats plugin in the Fiji ecosystem.

Assuming @mtbc and @melissalinkert are also happy with the last couple of changes, this should be ready to merge and release ome-common 6.0.0.

@sbesson sbesson merged commit a08e2d5 into ome:master Feb 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@manics manics deleted the manics:s3-service branch Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.