New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgData pixel sizes in custom units, not MICROMETERS #142

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@will-moore
Member

will-moore commented Feb 18, 2016

This fixes a bug in OMERO.figure caused by the fix in openmicroscopy/openmicroscopy#4460 and discussed in openmicroscopy/openmicroscopy#4460 (comment).

Since the imgData json from webgateway now alway uses MICROMETERS for pixel size units, when the units are different OMERO.figure needs to use the value for the custom unit.

To test, set the pixel size for an image to use different units as described https://www.openmicroscopy.org/site/support/omero5.2/developers/Python.html#create-image.
Add that image to a figure and see that the pixel size shown in right panel is correct.

@pwalczysko

This comment has been minimized.

Show comment
Hide comment
@pwalczysko

pwalczysko Feb 19, 2016

Member

Did some prep of data, will finish on Monday.

Member

pwalczysko commented Feb 19, 2016

Did some prep of data, will finish on Monday.

@chris-allan

This comment has been minimized.

Show comment
Hide comment
@chris-allan

chris-allan Feb 22, 2016

Member

Technically I don't see a problem with this approach. It feels a bit ugly to be replacing those properties like that when they are semantically different in another context with effectively the same naming but it certainly works.

Member

chris-allan commented Feb 22, 2016

Technically I don't see a problem with this approach. It feels a bit ugly to be replacing those properties like that when they are semantically different in another context with effectively the same naming but it certainly works.

@pwalczysko

This comment has been minimized.

Show comment
Hide comment
@pwalczysko

pwalczysko Feb 22, 2016

Member

Tested with real files with units of

  • dm
  • mm
  • nm

All worked fine as checked per display in Web and Insight comparing with
screen shot 2016-02-22 at 18 14 30

Member

pwalczysko commented Feb 22, 2016

Tested with real files with units of

  • dm
  • mm
  • nm

All worked fine as checked per display in Web and Insight comparing with
screen shot 2016-02-22 at 18 14 30

@will-moore

This comment has been minimized.

Show comment
Hide comment
@will-moore

will-moore Feb 23, 2016

Member

@chris-allan Agreed - that was just the quickest fix possible! But I'll look into adding different attributes for the non-converted values, and leave x and y in Microns....

Member

will-moore commented Feb 23, 2016

@chris-allan Agreed - that was just the quickest fix possible! But I'll look into adding different attributes for the non-converted values, and leave x and y in Microns....

@will-moore will-moore closed this Mar 10, 2016

@will-moore will-moore deleted the will-moore:vertical_labels_bug_pillow_3.1.0 branch Mar 10, 2016

@will-moore

This comment has been minimized.

Show comment
Hide comment
@will-moore

will-moore Mar 10, 2016

Member

This has been re-opened as #144 with new branch and rebased on latest master.

Member

will-moore commented Mar 10, 2016

This has been re-opened as #144 with new branch and rebased on latest master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment