New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slider range fix #213

Merged
merged 7 commits into from Jun 14, 2017

Conversation

Projects
None yet
5 participants
@will-moore
Member

will-moore commented May 5, 2017

As noticed by @bramalingam, if images have min-intensity above 9999 then the slider range min was incorrectly set at 9999, since this was hard coded.
Same is true for slider max.
This should now be fixed.

To test:

  • For image where min pixel intensity of a channel > 9999, channel slider min should be set correctly.
  • Same is true for images where max < -9999, but it might be tricky to find such an image, so I think we can assume that if the fix works for min, it also works for max.
@jburel

This comment has been minimized.

Show comment
Hide comment
@jburel

jburel May 9, 2017

Member

Do you have such images already imported?
if yes, could you indicate where they are?

Member

jburel commented May 9, 2017

Do you have such images already imported?
if yes, could you indicate where they are?

@bramalingam

This comment has been minimized.

Show comment
Hide comment
@bramalingam

bramalingam May 9, 2017

Member

@jburel : There were a couple of figures I had made with the python script, please check the following figure, http://web-dev-merge.openmicroscopy.org/figure/file/19810/

Member

bramalingam commented May 9, 2017

@jburel : There were a couple of figures I had made with the python script, please check the following figure, http://web-dev-merge.openmicroscopy.org/figure/file/19810/

@bramalingam

This comment has been minimized.

Show comment
Hide comment
@bramalingam

bramalingam May 9, 2017

Member

user-1 on eel

Member

bramalingam commented May 9, 2017

user-1 on eel

@jburel

This comment has been minimized.

Show comment
Hide comment
@jburel

jburel May 9, 2017

Member

The range issue is fixed.
The text box with the value is too small
Still no background for the slider.

Member

jburel commented May 9, 2017

The range issue is fixed.
The text box with the value is too small
Still no background for the slider.

@will-moore

This comment has been minimized.

Show comment
Hide comment
@will-moore

will-moore May 9, 2017

Member

The background for the slider is because the script we used has set the channel color to ffffff instead of FFFFFF which is what OMERO.figure expects.
If you set the channel colour to white in the app itself, you'll see the slider background grey.

Member

will-moore commented May 9, 2017

The background for the slider is because the script we used has set the channel color to ffffff instead of FFFFFF which is what OMERO.figure expects.
If you set the channel colour to white in the app itself, you'll see the slider background grey.

@will-moore

This comment has been minimized.

Show comment
Hide comment
@will-moore

will-moore May 9, 2017

Member

Last commit should fix the strange borders seen around image panels:

screen shot 2017-05-09 at 12 36 05

Member

will-moore commented May 9, 2017

Last commit should fix the strange borders seen around image panels:

screen shot 2017-05-09 at 12 36 05

@jburel

This comment has been minimized.

Show comment
Hide comment
@jburel

jburel May 9, 2017

Member

improving the "expected" value will be good i.e. handling both ffffff and FFFFFF

Member

jburel commented May 9, 2017

improving the "expected" value will be good i.e. handling both ffffff and FFFFFF

@will-moore

This comment has been minimized.

Show comment
Hide comment
@will-moore

will-moore Jun 6, 2017

Member

Last commits should fix the slider background on channels with colour ffffff and
fix strange black borders on the same file (http://web-dev-merge.openmicroscopy.org/figure/file/20006/), see #213 (comment).

NB: This PR includes tiny fixes to shape-editor.js which should be ported to a new shape-editor 2.0.1 but that repo is currently being migrated to ome...

Member

will-moore commented Jun 6, 2017

Last commits should fix the slider background on channels with colour ffffff and
fix strange black borders on the same file (http://web-dev-merge.openmicroscopy.org/figure/file/20006/), see #213 (comment).

NB: This PR includes tiny fixes to shape-editor.js which should be ported to a new shape-editor 2.0.1 but that repo is currently being migrated to ome...

@waxenegger

This comment has been minimized.

Show comment
Hide comment
@waxenegger

waxenegger Jun 7, 2017

Member

Latest change works, choosing white color results in #ccc background.

Member

waxenegger commented Jun 7, 2017

Latest change works, choosing white color results in #ccc background.

@snoopycrimecop snoopycrimecop referenced this pull request Jun 13, 2017

Merged

Reverse intensity #219

@jburel

This comment has been minimized.

Show comment
Hide comment
@jburel

jburel Jun 13, 2017

Member

@will-moore could you remove the console.log so we can merge it?
This PR prevents the reverse intensity one to be included

Member

jburel commented Jun 13, 2017

@will-moore could you remove the console.log so we can merge it?
This PR prevents the reverse intensity one to be included

@will-moore

This comment has been minimized.

Show comment
Hide comment
@will-moore

will-moore Jun 13, 2017

Member

@jburel Sorry, missed that. Removed it now.

Member

will-moore commented Jun 13, 2017

@jburel Sorry, missed that. Removed it now.

@jburel

This comment has been minimized.

Show comment
Hide comment
@jburel

jburel Jun 13, 2017

Member

Maybe also remove the change to shape-editor
This should be done in the correct repo

Member

jburel commented Jun 13, 2017

Maybe also remove the change to shape-editor
This should be done in the correct repo

@will-moore

This comment has been minimized.

Show comment
Hide comment
@will-moore

will-moore Jun 13, 2017

Member

@jburel Removed changes to shape-editor.

Member

will-moore commented Jun 13, 2017

@jburel Removed changes to shape-editor.

@jburel

This comment has been minimized.

Show comment
Hide comment
@jburel

jburel Jun 13, 2017

Member

Changes can be made against https://github.com/ome/shape-editor
we can then tag and include the new version in the coming release of figure

Member

jburel commented Jun 13, 2017

Changes can be made against https://github.com/ome/shape-editor
we can then tag and include the new version in the coming release of figure

@jburel jburel merged commit ff825d0 into ome:master Jun 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jburel jburel added this to the 3.1.0 milestone Jun 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment