New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function arguments and conversion between radians and degrees #236

Merged
merged 2 commits into from Jul 7, 2017

Conversation

Projects
None yet
4 participants
@carandraug
Copy link
Contributor

carandraug commented Jul 4, 2017

While checking how the rotation is done to add a button for horizontal flip, I noticed this unused arguments and extra computations.

@jburel

This comment has been minimized.

Copy link
Member

jburel commented Jul 5, 2017

Adding the include flag so it can be part of the daily merge build
--include

@joshmoore

This comment has been minimized.

Copy link
Member

joshmoore commented Jul 5, 2017

NB: This may well should be considered a breaking change. An alternative would be to replace use of this.r with rotation within the function method. However, as is always the case with an unused argument, someone with the background should likely evaluate what was really intended.

@jburel

This comment has been minimized.

Copy link
Member

jburel commented Jul 5, 2017

  • the conversion changes makes sense
  • better to introduce a new function taking 2 arguments and marking the existing correct_rotation as deprecated.
@will-moore

This comment has been minimized.

Copy link
Member

will-moore commented Jul 5, 2017

Since the third argument rotation wasn't being used, it's not a breaking change to remove that argument. Users could still call it with 3 arguments without an error.
Also, I wouldn't usually consider methods on a View to be an API that could/would be used externally.

@jburel

This comment has been minimized.

Copy link
Member

jburel commented Jul 6, 2017

True that js offers "such flexibility" (not sure it is a good thing!)

@jburel jburel merged commit 2fc85c3 into ome:master Jul 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jburel

This comment has been minimized.

Copy link
Member

jburel commented Jul 7, 2017

Thanks

@jburel jburel added this to the 3.1.2 milestone Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment