New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix theZ display in crop dialog #258

Merged
merged 1 commit into from Jan 12, 2018

Conversation

Projects
None yet
2 participants
@will-moore
Member

will-moore commented Jan 11, 2018

Fixes https://trello.com/c/imMLEy89/100-bug-figure-crop-dialog-thez-display

To test:

  • Add rectangles on a multi-Z image in Insight, so that the Z range goes from below 100 to over 100 OR from below 10 to above 10.

  • Add the image to a Figure and click on the Crop button to launch the dialog

  • Check that the Z-index ranges are the same as created in Insight.

Before and after shots below:

screen shot 2018-01-11 at 16 15 47
screen shot 2018-01-11 at 16 16 12

@jburel jburel added this to the 3.2.0 milestone Jan 11, 2018

@jburel

This comment has been minimized.

Member

jburel commented Jan 12, 2018

@will-moore could you please indicate an image with a large number of z-sections on eel?

@jburel

This comment has been minimized.

Member

jburel commented Jan 12, 2018

Works as expected
I also checked ROI edit and no problem there

@jburel jburel merged commit 7afa6fd into ome:master Jan 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment