New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reportlab_3_4_bugfix #260

Merged
merged 1 commit into from Jan 24, 2018

Conversation

Projects
None yet
2 participants
@will-moore
Member

will-moore commented Jan 23, 2018

Fixes https://trello.com/c/KEIu1LhB/17-bug-reportlab-34-export

This fixes an error seen when exporting a figure with lots of images, so that the Info section is more than 1 page. Only seen with reportlab 3.4.0.

To test:

  • need to install reportlab 3.4.0
  • Add lots (e.g. 20) images to a figure and export PDF
  • Check that you can export 2 or more info pages
  • NB: Also good to check that this doesn't break using reportlab installed via yum install python-reportlab as on web-dev-merge.

@will-moore will-moore changed the title from Fix export of multiple info pages with reportlab 3.4 to reportlab_3_4_bugfix Jan 23, 2018

@jburel

This comment has been minimized.

Member

jburel commented Jan 23, 2018

Note that the web-* do not have that version of reportlab installed.

@jburel

This comment has been minimized.

Member

jburel commented Jan 24, 2018

eel (python-reportlab):

  • Export a figure with 45 images: one single page, 3 pages of "info" are added. Export works as expected
  • Export a figure with 45 images: 3 pages, 3 pages of "info" are added. Export works as expected

@jburel jburel added this to the 3.2.0 milestone Jan 24, 2018

@jburel

This comment has been minimized.

Member

jburel commented Jan 24, 2018

While reviewing this PR, open with on when a dataset is selected will be a nice feature to have

@jburel

This comment has been minimized.

Member

jburel commented Jan 24, 2018

Repeated the same tests with reportlab 3.4.0
everything works as expected
Thanks @will-moore
merging so it is included in the coming release

@jburel jburel merged commit 32ab9ee into ome:master Jan 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment