New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optional #269

Merged
merged 2 commits into from Feb 9, 2018

Conversation

Projects
None yet
2 participants
@jburel
Copy link
Member

jburel commented Feb 8, 2018

Fix an error when trying to export unsaved figures as PDF/TIFF

see https://trello.com/c/YkngbZ79/175-export-without-saving-figure

cc @will-moore

To test:

  • Open an image in Figure. DO NOT SAVE THE FIGURE
  • Export the figure
@will-moore

This comment has been minimized.

Copy link
Member

will-moore commented Feb 9, 2018

Code looks good. Export of unsaved figure works OK on web-dev-merge.
Travis is green. Good to merge.

@jburel jburel merged commit 4fe74a1 into ome:master Feb 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jburel jburel added this to the 3.2.1 milestone Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment