Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix invalid panel dx/dy offsets #294
I think you'll need to call your fix on each panel, not on the figure_json, since
Or you could iterate through all the panels in your
@jburel comment was about having the default logic in a single place (that variable is used in 4 places). Because this change reduces the use of that logic to a single place, using a variable to reduce its duplication is no longer necessary. Unless
I've not tested yet but looks good.
No problem. We already are using a modified version of the script that skips the annotation after the build.
I have changed the comment style to follow pep 8
The proposed changes should handle the scenario where the
dx key or the
dy key exists but has a null value and set its value to
DEFAULT_OFFSET in the context of the export script.
The change reverts the usage of
dict.key(key, default) introduced in 77fd869. This logic would still be necessary if the keys could be missing under certain conditions as the script would raise a
KeyError. Since the original PR (#257) was attempting to fix the same bug as here, it is possible the code path defining a default dictionary value in the getter was never used in practice. Leaving @will-moore to comment on this point.