New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix render_scaled_region for Pillow 4.2 #300

Merged
merged 2 commits into from Aug 27, 2018

Conversation

Projects
None yet
3 participants
@will-moore
Member

will-moore commented Jun 25, 2018

This fixes this issue python-pillow/Pillow#2609 reported by @pwalczysko using pillow==4.2.1.

To test, add a Big Image to figure and check that it renders OK.

@pwalczysko

This comment has been minimized.

Show comment
Hide comment
@pwalczysko

pwalczysko Jun 25, 2018

Member

This change works for me on the localhost mac os x, with pillow 4.2.1 (installed using conda)

Member

pwalczysko commented Jun 25, 2018

This change works for me on the localhost mac os x, with pillow 4.2.1 (installed using conda)

@jburel

This comment has been minimized.

Show comment
Hide comment
@jburel

jburel Jul 24, 2018

Member

Has this been tested with other version of Pillow?

Member

jburel commented Jul 24, 2018

Has this been tested with other version of Pillow?

@jburel

This comment has been minimized.

Show comment
Hide comment
@jburel

jburel Jul 26, 2018

Member

Does the problem only occur when generating a jpg?

Member

jburel commented Jul 26, 2018

Does the problem only occur when generating a jpg?

@will-moore

This comment has been minimized.

Show comment
Hide comment
@will-moore

will-moore Aug 13, 2018

Member

There's nowhere else in views.py or Export script that we're saving PIL image as JPEG, so nowhere else needs fixing.
However, I made the same RGB change at views.py def default_thumbnail in case this changes to saving as JPG in future. Functionality is unchanged.

Member

will-moore commented Aug 13, 2018

There's nowhere else in views.py or Export script that we're saving PIL image as JPEG, so nowhere else needs fixing.
However, I made the same RGB change at views.py def default_thumbnail in case this changes to saving as JPG in future. Functionality is unchanged.

@jburel jburel added this to the 4.0.1 milestone Aug 27, 2018

@jburel

This comment has been minimized.

Show comment
Hide comment
@jburel
Member

jburel commented Aug 27, 2018

Thanks @will-moore

@jburel jburel merged commit f0daff9 into ome:master Aug 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment