New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z slider bugfixes #303

Merged
merged 3 commits into from Jul 25, 2018

Conversation

Projects
None yet
2 participants
@will-moore
Member

will-moore commented Jul 6, 2018

See https://trello.com/c/zXvu3QjV/202-bug-z-slider-bugs

To test:

  • Clicking Z / T increment buttons should update Z/T labels and the slider position.
  • Selecting the Z/T slider handle, then using the arrow keys to increment the slider should not nudge the selected panels in the figure.
  • Check other Z/T slider & label functionality is unchanged: Test images with different Z/T sizes and values.

@jburel jburel added this to the 4.0.1 milestone Jul 25, 2018

@jburel

This comment has been minimized.

Show comment
Hide comment
@jburel

jburel Jul 25, 2018

Member

Tested the changes
Everything works as expected.
Display of time using unit will need to be reviewed.
e.g. an image with 6 timepoints show 0 secs all the time.
This is outside the scope of this PR

Member

jburel commented Jul 25, 2018

Tested the changes
Everything works as expected.
Display of time using unit will need to be reviewed.
e.g. an image with 6 timepoints show 0 secs all the time.
This is outside the scope of this PR

@jburel jburel merged commit 51be8dd into ome:master Jul 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment