New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

big image scalebar fix #304

Merged
merged 2 commits into from Jul 26, 2018

Conversation

Projects
None yet
3 participants
@will-moore
Member

will-moore commented Jul 9, 2018

Bug fix: See https://trello.com/c/S78nkV0c/203-bug-scalebars-in-exported-pdf-big-images (reported at https://www.openmicroscopy.org/community/viewtopic.php?f=4&t=8523&p=19515)

To test:

  • Check that scalebars are drawn correctly at various zoom levels of a big image.
  • I did this by drawing ROI lines of known length in iviewer, using the scalebar on the image.
  • Then add these Lines as ROIs in figure and add scalebars of corresponding length, e.g. screenshot below:
  • Add some scalebars to non-big images to check they still work OK.
  • Export to PDF & TIFF and check that scalebars show up at same level as in web.

screen shot 2018-07-09 at 12 51 10

@will-moore will-moore changed the title from Scale the pixel_size and scalebar correctly for big images to big image scalebar fix Jul 17, 2018

@rgozim

This comment has been minimized.

Show comment
Hide comment
@rgozim

rgozim Jul 17, 2018

Member

Seems okay to me.

Member

rgozim commented Jul 17, 2018

Seems okay to me.

@jburel jburel added this to the 4.0.1 milestone Jul 25, 2018

@jburel

This comment has been minimized.

Show comment
Hide comment
@jburel

jburel Jul 26, 2018

Member

Having the unit only hard-coded in microns is far from ideal for big images.
Adding a card since we should fix that
https://trello.com/c/R2mWNfR9/205-scale-bar-unit

Member

jburel commented Jul 26, 2018

Having the unit only hard-coded in microns is far from ideal for big images.
Adding a card since we should fix that
https://trello.com/c/R2mWNfR9/205-scale-bar-unit

@jburel jburel merged commit cbc4c07 into ome:master Jul 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment