Delete check parent links

[will-moore]

See https://forum.image.sc/t/caution-with-copy-links-in-omero/33680

We do a simple check for multiple parents and if found, show a Warning message:

To test:

• Select 1 or more Images or Datasets or Plates where at least one of the selected objects has multiple Parents.
• Click Delete.
• Should see the warning above.
• Also check warning is not shown when not needed.

[joshmoore]

@dominikl, @jburel : how hard would it be to have a similar dialog in insight?

[jburel]

We already have a confirmation dialog so it will be a matter of adding a check and add the warning message.
Insight has already a warning message (divergence between web/insight)

I will have a look

[jburel]

if I understand the dialog correctly as soon as one image has more than one parent the warning is displayed. So the loop could be stop as soon as multiple is true

[will-moore]

If I want to break out of the loop early then I have to switch to using a for loop, which is slightly less nice coding style (I prefer the 'functional' style). I don't think you will notice much performance improvement to break early but can refactor if you want?

[jburel]

i understand but we have seen cases where people were trying to delete a large number of objects from the UI
so it will be good to see if it makes a major change in performance.

[will-moore]

This code is running after we make a call to the server, which takes e.g. 162 millisecs for 46 images (just tried that). I imagine the refactor will save maybe a few millisecs and won't be noticed compared to the time to load the data. With a large number of images the effect will be even smaller since it will take longer to load the data.
If you want me to spend time to analyse the performance under various conditions (for loop vv forEach and many images where the first has multiple parents vv many images where none of the images have multiple parents (so we don't break early) then I can do, but I think that would not be the best use of time.

[jburel]

Thanks for checking

If you want me to spend time to analyse the performance under various conditions (for loop vv forEach and many images where the first has multiple parents vv many images where none of the images have multiple parents (so we don't break early) then I can do, but I think that would not be the best use of time.

This is not what I was suggesting. Nonetheless we need to keep in mind performance and large volume since it is the reality! and break early if required.
For this call, it seems that we might not have a significant performance degradation.

[jburel]

Actually insight has already a check in place for images

[jburel]

Unfortunately this will partially prevent the lost of image data.
Follow is a use case that will delete the image. The user is very likely to delete a dataset.

• Add an image to 2 datasets, d1 and d2.
• d1 is only in one project or orphan
• Select to delete d1.
• The image will be also deleted and "disappear" from d2

[will-moore]

@jburel If you delete a Dataset, any Images in it that are also in another Dataset won't get deleted.

[jburel]

I got mislead by the UI, you are correct
It is deleting from the display but a refresh "brings" it back
I forgot about that strange behaviour

[jburel]

The UI bug should be fixed

[will-moore]

@jburel That last commit should fix the bug you noticed.

[jburel]

Thanks @will-moore , the shared image is now removed from the second dataset when the first dataset is deleted.