Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI to GitHub actions #240

Merged
merged 3 commits into from
Nov 5, 2020
Merged

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Oct 20, 2020

Largely inspired by the work in omero-py this migrates the CI to using GitHub actions and also adds coverage for Python 3.7 and 3.8

  • create GitHub workflow with 3 steps: install from source, test and publish
  • remove Travis-specific environment from tox.ini and use markers like omero-py
  • expand envlist to run tests under Python 3.7 and 3.8
  • remove .travis.yml
  • update CI badge and add badge for PyPI

- create GitHub workflow with 3 steps: install from source, test and publish
- remove Travis-specific environment from tox.ini and use markers like omero-py
- expand envlist to run tests under Python 3.7 and 3.8
- remove .travis.yml
@joshmoore
Copy link
Member

joshmoore commented Oct 20, 2020

In general, big 👍. I'd still like to see some for of re-use, but I'm failing to see an easy path forward where changes can be propagated:

@manics
Copy link
Member

manics commented Oct 20, 2020

To reuse this you'd probably want to split it into several github actions which do one thing, e.g. install standard dependencies, run standard scripts, a bit like https://github.com/ome/omero-test-infra but with one action per step (and with less coupling?) instead of bundling everything together.

@sbesson
Copy link
Member Author

sbesson commented Oct 29, 2020

Folllowing the preliminary work on omero-cli-zarr and ome/.github#4, I went ahead and split the single workflow into 3 workflows. The PyPI publication should match the proposed template and I would assume the Tox one could also be turned into a template

@sbesson
Copy link
Member Author

sbesson commented Nov 5, 2020

Relisting for a last round of comments and objections to merging this in the current state?
Proposed next step as a few of our Python libraries are using tox is to test the tox workflow and eventually convert it into a template.

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, big 👍. Some of the badges are hard to confirm until after this is merged, but certainly no objections to iterating through this. Thanks.

@sbesson sbesson merged commit 7661bd6 into ome:master Nov 5, 2020
@sbesson sbesson deleted the travis2ghactions branch November 5, 2020 10:17
@sbesson sbesson mentioned this pull request Dec 5, 2020
@sbesson sbesson mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants