Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8052 web chgrp #113

Merged
merged 16 commits into from Mar 21, 2012

Conversation

@will-moore
Copy link
Member

commented Mar 7, 2012

Rebased on develop today.

Allows moving of objects to chosen group via right-click in tree.
No support for choosing destination Project or Dataset etc.

will-moore added 15 commits Feb 6, 2012
chgrpObject() added to Blitz Gateway. See #8014
Conflicts:

	components/tools/OmeroPy/src/omero/gateway/__init__.py
Blitz Gateway createGroup() method.
TODO: move webclient_gateway functionality to use this method.
Basic working chgrp in web.
Interesting chgrp errors sometimes caused by refreshing page during
chgrp. Results in multi-group access (all objects from all groups
appear in tree). This remains the behavior until you switch groups
Blitz chgrpObject() returns prx without waiting
Allows calling code to continue asynchronously and wait on the cheque callback.
Gateway chgrp asynchronous test
Trying to reproduce 'race condition'? bugs seen in web.
Minor bug-fixes for web chgrp
Fixed 'inprogress' count for chgrps, don't allow chgrp for 'Orphaned'.
Better chgrp icon in context menu etc.
Merge remote-tracking branch 'ome/develop' into 8052_web_chgrp
Conflicts:
	components/tools/OmeroPy/src/omero/gateway/__init__.py
@olatarkowska

This comment has been minimized.

Copy link
Member

commented Mar 20, 2012

As agreed final testing and merging with develop will be taken by @joshmoore this week.

image = self.image
dataset = image.getParent()
orig_gid = dataset.getDetails().getGroup().id
print "Original Group", orig_gid

This comment has been minimized.

Copy link
@joshmoore

joshmoore Mar 20, 2012

Member

Let's not use print in tests (after the debugging phase). If necessary, let's setup logging so that it can be disabled/enabled without changing code

@joshmoore

This comment has been minimized.

Copy link
Member

commented Mar 20, 2012

chgrp items

  • We should move the method to chgrpObjects to match deleteObjects, but this is waiting on DoAll, as I understand it.
  • Should there be an icon to match delete/copy? And if so, what would that look like?
  • Is there another ticket/story for the handling of target projects/datasets as well as annotation options, etc?

Items/thoughts not related to chgrp

As discussed with Will, this branch has some issues with the group drop-down which will go away soon, which I'll mention here just to record the status:

  • The drop-down sometimes shows a different current than the current one. Re-choosing usually fixes the situation
  • The activities menu might should disappear on "esc" as well as re-clicking on the activities icon
  • I got confused by the activities icon 😄 and understood it to be refresh
  • By default, testing fails even with just gatewaytest/chgrp.py on "too many open files" (ticket 5177)
@will-moore

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2012

  • Tickets for chgrp-2 in web are #8339 & #8340.
  • The icon improvement will be left to Dom.

Other issues:

  • Drop-down group switcher is a known minor issue that will go away with the UI and multi-group changes
  • Activities panel closing: #8343 (icon is already changing)
@joshmoore

This comment has been minimized.

Copy link
Member

commented Mar 21, 2012

Cool, Will. Merging.

joshmoore added a commit that referenced this pull request Mar 21, 2012
Merge pull request #113 from will-moore/8052_web_chgrp
Support for chgrp in OMERO.web.

@joshmoore joshmoore merged commit 5343147 into ome:develop Mar 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.