Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-navigation items unclickable when navigation menu wraps in Default theme #1453

Closed
joebauer opened this issue Sep 24, 2019 · 14 comments
Closed

Comments

@joebauer
Copy link

I’m seeing that when you set up child navigation menu items in the Default theme and when you navigate to the site and narrow your window enough that the menu items wrap so there are two rows, that the sub-menu navigation items on the top row are essentially un-navigatable because you can’t make your mouse jump the gap to the sub-items. Like this:
Screen Shot 2019-09-23 at 3 22 32 PM

In this you can see the row of “Fake navigation menu item” navigation items wrap due to the narrow screen, but when I hover over the “Fake Navigation Menu Item with Sub menu items” the drop-down goes under the second row of navigation items, so the mouse can’t get to it and the sub-items disappear when you attempt to do so.

Here's what it looks like on the admin console:
Screen Shot 2019-09-23 at 3 37 12 PM

I've tried this with vanilla installs of the Default theme in Omeka S version 1.4.0 and 2.0.2.

Is there a fix or workaround for this?

Thanks!

kimisgold added a commit to omeka-s-themes/default that referenced this issue Sep 24, 2019
@kimisgold
Copy link
Member

Hi, @joebauer. I've got a proposed fix in a branch over in the default theme's repository. With it, the navigation remains one line of items, but the individual items' text wraps. This should keep the dropdown menus from getting separated from their parent items. Could you try it out and let me know if it works for you? To do that, copy this version of style.css into themes/default/asset/css/style.css within your Omeka S installation.

@joebauer
Copy link
Author

joebauer commented Sep 24, 2019 via email

@kimisgold
Copy link
Member

It needs to go through more internal testing, but after that I hope to do another release within the week.

@joebauer
Copy link
Author

That sounds great! Thanks again for the super fast response on this!

@zerocrates
Copy link
Member

The fix is available in version 1.4.2 of the default theme.

@m-art-in
Copy link

Sorry, I still have the bug with 1.4.2

@kimisgold
Copy link
Member

@m-art-in Just to cover our bases, have you cleared your cache/performed a hard refresh?

@m-art-in
Copy link

it's a fresh/new installation, so no cache problem

@kimisgold
Copy link
Member

Could you provide a live site or screenshot to look at?

@m-art-in
Copy link

It's on a local test machine, but here is a screen shot:
image

I hover with the mouse over "Digitale Bibliothek" but when I try to click e.g. "Drucke" the menu disappears right away.
and thats the Navigation in the backend:

image

@kimisgold
Copy link
Member

I found some bottom padding on the header that I somehow missed when I made the fix. It should be simple to address and test. Thanks for bringing this to our attention!

@kimisgold kimisgold reopened this Nov 14, 2019
@m-art-in
Copy link

@kimisgold thank you very much! Would be great to have a fix soon. Unfortunately, I don't know how I could do it myself. I have only noticed the issue...

kimisgold added a commit to omeka-s-themes/default that referenced this issue Nov 14, 2019
@kimisgold
Copy link
Member

We've released v1.4.3 with a fix: https://github.com/omeka-s-themes/default/releases/download/v1.4.3/default-v1.4.3.zip

@m-art-in
Copy link

m-art-in commented Nov 18, 2019

Thank you! Now it's working fine - Issued can be closed again.

@zerocrates zerocrates added this to the November 18 2019 milestone Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants