Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to give attributes to img tag in media show page #1207

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@pols12
Copy link
Contributor

commented Feb 1, 2018

Especially alt attribute which is recommanded for accessibility.

Yanyufish asked to have alt tag for images on the forum.

pols12 added some commits Feb 1, 2018

Let ThumbnailRenderer pass attributes for img tag
Allow to give a value (e.g. picked from a property) to `alt` attribute in view templates.
@zerocrates

This comment has been minimized.

Copy link
Member

commented Feb 7, 2018

Passing attributes seems like a good option to have here, though we might want to tweak the option name to clarify that these are attributes for an image (or even thumbnail image) only.

The specific use of the alt for the media on its own show page, I'm not so sure of though. In that context the title is already on the page and highly accessible through the title and heading elements. I'm not sure that having it also as the alt of the image is actually an accessibility improvement over the default blank alt there.

@pols12

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2018

The specific use of the alt for the media on its own show page, I'm not so sure of though. In that context the title is already on the page and highly accessible through the title and heading elements. I'm not sure that having it also as the alt of the image is actually an accessibility improvement over the default blank alt there.

Indeed, title brings no new information, that’s what @patrickmj has said on the forum too.

I proposed to use dcterms:description. I’m not a semantic web specialist: would it be interesting to use a custom property (in omeka vocabulary) which would be defined as owl:equivalentProperty of cwork:altText?

@zerocrates

This comment has been minimized.

Copy link
Member

commented Feb 7, 2018

@zerocrates

This comment has been minimized.

Copy link
Member

commented May 24, 2018

I cherry-picked the first commit out of here (just adding the attribute passing for thumbnail rendering), but I changed the option name to thumbnailAttribs to avoid any future conflict or confusion with other possible attribute options.

zerocrates added a commit that referenced this pull request May 29, 2018

@zerocrates zerocrates closed this Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.