Get values of different types in one time. #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be useful to get value of different types with
resource->value(), for example to get all resources and all uris at the same time. The main issue here are the typesresource,resource:item,resource:itemsetandresource:media. If I need all linked items, I should get allresource, filter them, then get allresource:item. This pr avoids two calls, but not the filter.In fact, the type
resourceshould not be used in the database, onlyresource:item. It is only a shortcut to use in the resource template. So when a linkresourceis saved, it should be saved with the type of the resource. I added an automatic conversion in the BulkEdit module, but it should be done during the migration to Omeka S 3. I can pr the small js change and the migration file if you think it's a good thing.