Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing tinymce updates #19

Closed
patrickmj opened this issue Feb 7, 2018 · 7 comments
Closed

Testing tinymce updates #19

patrickmj opened this issue Feb 7, 2018 · 7 comments
Assignees
Labels

Comments

@patrickmj
Copy link
Contributor

patrickmj commented Feb 7, 2018

On the tinymce4 branch of UserProfiles, and master of Omeka core, creating and editing is ready for a look.

Admin side: create UP structures, and create profiles for individual users
Public side: edit profiles, and especially check the process across themes and theme settings

@mebrett
Copy link

mebrett commented Feb 8, 2018

General functionality works on public and admin sides. When on the public side, you have the option of not using HTML, but with the box checked tinyMCE displays fine.

Theme-specific things:

  • Thanks Roy, Emiglio, Big Picture, and Thanks Roy are fine.
  • Santa Fe and Berlin have an oddly large space between the heading and the text.
  • Rhythm - edit button on the public side only has legible text on hover (otherwise the text is the same color as the button background).
  • Center Row is mostly fine, alignment is a little odd.
  • The Daily looks rather weird.
  • Seasons: the profile title is a little off in its display.

Berlin

berlin

The Daily:

thedaily

Seasons:

screen shot 2018-02-08 at 1 44 52 pm

@patrickmj patrickmj self-assigned this Feb 13, 2018
@patrickmj
Copy link
Contributor Author

Latest on tinymce4 addresses some the issues, but the cross-theme compatibility is something I'll need to consult with @kimisgold about.

@patrickmj
Copy link
Contributor Author

The buttons on the public edit page are also a thing to look in to.

@mebrett
Copy link

mebrett commented Feb 14, 2018

One problem which I think straddles this issue and #20 is the placement of the "use html" checkbox on most themes - if you have multiple inputs, it ends up under the "remove" button in such a way that it looks like it's associated with the element below rather than above.

Ex.
screen shot 2018-02-14 at 2 13 19 pm

@zerocrates
Copy link
Member

do we have a sense of our status here?

@patrickmj
Copy link
Contributor Author

Theme wonkiness that I'm not sure how to address, but no complaints about the tinymce stuff. So, if we really want to make sure something is out there that matches the core tinymce change we could probably release it then do another quick release after we fix the styling (I don't really know when the styling got busted, but it seem unrelated to the tinymce stuff)

@patrickmj
Copy link
Contributor Author

patrickmj commented Feb 15, 2018

@zerocrates From the stuff in #20, looks like this might need a serious rewrite. The original intent was to intrude as little as possible on how the theme wants things to look. However, little special pieces of CSS needed to get inserted here and there. Now, it looks like we need to bail on that idea and force everything into how the plugin demands things to work.

Unless you or Kim see a way out of that trap.

@mebrett mebrett closed this as completed Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants