Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Javascript in /pages html files to External File #50

Closed
omicreativedev opened this issue Oct 8, 2023 · 5 comments
Closed

Move Javascript in /pages html files to External File #50

omicreativedev opened this issue Oct 8, 2023 · 5 comments

Comments

@omicreativedev
Copy link
Owner

Currently each of the files in the /pages folder has Javascript to switch the theme.
Move this code to /pages/themeswitcher_subdir.js
Update thankyou.html and omicreativedev.html with the external script

If assigned, please fork immediately.
Comment within 2 days (at least leave a comment) if you haven't done a PR yet.
Resign yourself if you won't get to it so someone else can.??

Be creative.
Read the Docs.
Give a ⭐
Don't break anything. :)

@omicreativedev omicreativedev added good first issue Good for newcomers hacktoberfest Hacktoberfest 2023 Contribution first-timers For first timers first-timers-friendly First Timers Friendly javascript Javascript beginner-friendly Beginner Friendly up-for-grabs Up For Grabs your-first-pr Your First PR labels Oct 8, 2023
@Creperi
Copy link

Creperi commented Oct 8, 2023

Me.

@omicreativedev
Copy link
Owner Author

@Creperi You are assigned.

@omicreativedev
Copy link
Owner Author

@Creperi
I saw your previous pull. Nice work.
You don't have to update index.html as it's already done.
We need to just do thankyou.html and omicreativedev.html
Instead of main.js we want to use ./themeswitcher_subdir.js as the filename

@omicreativedev omicreativedev added the assigned Issue Assigned label Oct 8, 2023
@Creperi
Copy link

Creperi commented Oct 8, 2023

Thanks. I was confused.

@Creperi
Copy link

Creperi commented Oct 8, 2023

Anyway i solved the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants