New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates `omise-php` version to 2.9.1 #147

Merged
merged 1 commit into from Sep 4, 2018

Conversation

Projects
None yet
3 participants
@jonrandy
Contributor

jonrandy commented Aug 31, 2018

1. Objective

Update Omise-PHP to the newest version

2. Description of change

Omise-PHP was replaced with the newest version in the lib folder

3. Quality assurance

Checked to make sure all current functionality still working

4. Impact of the change

We can use all the newest features from omise-php in our development

5. Priority of change

Normal

6. Additional Notes

馃檲馃檳馃檴

@jacekstan

This comment has been minimized.

Show comment
Hide comment
@jacekstan

jacekstan Sep 3, 2018

Contributor

approving..
but I guess.. it is not necessary...
you need to add soon the newest version as soon as instalment api is implemented in omise-php, and that version will be the one to integrate..
this one probably can be skipped..

Contributor

jacekstan commented Sep 3, 2018

approving..
but I guess.. it is not necessary...
you need to add soon the newest version as soon as instalment api is implemented in omise-php, and that version will be the one to integrate..
this one probably can be skipped..

@jonrandy

This comment has been minimized.

Show comment
Hide comment
@jonrandy

jonrandy Sep 4, 2018

Contributor

Will form part of a release before release containing instalment payments

Contributor

jonrandy commented Sep 4, 2018

Will form part of a release before release containing instalment payments

@jonrandy jonrandy merged commit d309a93 into 1-stable Sep 4, 2018

@jonrandy jonrandy deleted the 1-update-omise-php branch Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment