MAG1: Proper set Magento payment object's transaction id after create a new charge / capture an authorized charge. #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
There is a proper way to keep record payment gateway's transaction with Magento order system which is, transaction feature.
This reference id (transaction id) will be used in various situations i.e. you can't make a refund or void without have a transaction id as a reference.
For example:
Invoice tab
Transaction tab
If you take a look on those screenshots, you will see that this order has an invoice but transaction hasn't been recorded properly.
2. Description of change
Then, transaction between Omise and Magento will be recorded at the order's transaction tab.
Also, transaction id will be recorded at order history section.
3. Quality assurance
🔧 Environments:
v1.9.3.6
.v5.6.30
.✏️ Details:
Create charge with Internet Banking payment method.
Capture an authorized charge.
Transaction object will be created and attached to Magento's payment object in any of above cases.
4. Impact of the change
None.
5. Priority of change
Normal
6. Additional Notes
None.