Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAG1: Proper set Magento payment object's transaction id after create a new charge / capture an authorized charge. #96

Merged
merged 1 commit into from Nov 7, 2017

Conversation

guzzilar
Copy link
Contributor

@guzzilar guzzilar commented Nov 7, 2017

1. Objective

There is a proper way to keep record payment gateway's transaction with Magento order system which is, transaction feature.

This reference id (transaction id) will be used in various situations i.e. you can't make a refund or void without have a transaction id as a reference.

For example:

  1. Invoice tab
    screen shot 2560-11-07 at 9 00 27 pm

  2. Transaction tab
    screen shot 2560-11-07 at 9 00 29 pm

If you take a look on those screenshots, you will see that this order has an invoice but transaction hasn't been recorded properly.

2. Description of change

  1. Set transaction id into payment object with Omise charge id.

Then, transaction between Omise and Magento will be recorded at the order's transaction tab.
screen shot 2560-11-07 at 9 07 41 pm

Also, transaction id will be recorded at order history section.
screen shot 2560-11-07 at 9 07 50 pm

3. Quality assurance

🔧 Environments:

  • Magento CE: v1.9.3.6.
  • PHP: v5.6.30.

✏️ Details:

  1. Create charge with Credit Card payment method.
  • Authorize only
  • Authorize and capture
  • 3-D Secure payment: Authorize only
  • 3-D Secure payment: Authorize and capture
  1. Create charge with Internet Banking payment method.

  2. Capture an authorized charge.

Transaction object will be created and attached to Magento's payment object in any of above cases.

4. Impact of the change

None.

5. Priority of change

Normal

6. Additional Notes

None.

@guzzilar
Copy link
Contributor Author

guzzilar commented Nov 7, 2017

👍

@guzzilar guzzilar merged commit cba9e71 into 1-stable Nov 7, 2017
@guzzilar guzzilar deleted the 1-set-transaction-id branch November 7, 2017 16:49
@A-Kits
Copy link

A-Kits commented Nov 9, 2017 via email

@guzzilar
Copy link
Contributor Author

guzzilar commented Nov 9, 2017

@A-Kits อันนี้บัญชี Omise ที่ใช้ได้เปิด 3-D Secure ไว้หรือปล่าวนะครับ?

หมายเหตุ. ผมกำลังเปิด pull request ในส่วนของปรับปรุง order status และ payment flow ทั้งหมด
หากคุณ @A-Kits สนใจยังไง สามารถตรวจสอบข้อมูลได้ที่ลิงค์ #97 นะครับ

@A-Kits
Copy link

A-Kits commented Nov 10, 2017 via email

@guzzilar guzzilar changed the title Proper set Magento payment object's transaction id after create a new charge / capture an authorized charge. MAG1: Proper set Magento payment object's transaction id after create a new charge / capture an authorized charge. Nov 12, 2017
@guzzilar guzzilar mentioned this pull request Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants