New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the software version to be the detailed request information on Omise dashboard #29

Merged
merged 2 commits into from Oct 12, 2017

Conversation

Projects
None yet
1 participant
@nimid
Contributor

nimid commented Oct 12, 2017

1. Objective

Specify the Omise PrestaShop version and PrestaShop version to be the detailed request information on Omise dashboard. (The request such as charge request.)

These information, Omise PrestaShop version and PrestaShop version, are useful, for examples, when technical problems occur, these information can help to identify the cause of problem easier or these information can be historical data that may be used as analytical data.

Related information:

  • Related issue: -
  • Related ticket: -

2. Description of change

Define a constant, OMISE_USER_AGENT_SUFFIX. The value of constant is Omise PrestaShop version and PrestaShop version.

The constant has been defined for the front office part only. The back office part does not need this constant.

3. Quality assurance

Environments:

  • Platform: PrestaShop 1.6.1.17
  • Omise plugin: Omise PrestaShop 1.2
  • PHP: 5.6.31

Details:

Before change
The screenshot below shows the Omise dashboard. In the red box, the user agent information has only Omise PHP version.

before-change-user-agent-has-only-omise-php-version

After change
The screenshot below shows the Omise dashboard. In the red box, the Omise PrestaShop version and PrestaShop version have been added to the user agent information.

after-change-omise-prestashop-version-and-prestashop-version-have-been-added

4. Impact of the change

-

5. Priority of change

Normal

6. Additional notes

More information about user agent.

nimid added some commits Oct 11, 2017

Attach versions when create Omise charge request
Define a constant, OMISE_USER_AGENT_SUFFIX. This constant contains Omise
PrestaShop version and PrestaShop version. It will be attached and sent
to Omise API for creating Omise charge.

@nimid nimid merged commit c159071 into master Oct 12, 2017

@nimid nimid deleted the attach-user-agent-suffix branch Oct 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment