Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change text domain as same as plugin directory name. #32

Merged
merged 1 commit into from Apr 18, 2017

Conversation

@mayukojpn
Copy link
Contributor

mayukojpn commented Oct 20, 2016

1. Objective reason

This plugin is not translatable on GlotPress, the tool which allows every locale team to manage WordPress plugin translation and generate/provide language pack.

Related ticket: Not translatable with GrotPress. #31

2. Description of change

Change text domain as same as plugin directory name.

3. Users affected by the change

Translation editors.

4. Impact of the change

I believe nothing.

5. Priority of change

not high

6. Alternate solution (if any)

Ask translation editors to do with old way.

@nimid

This comment has been minimized.

Copy link
Contributor

nimid commented Oct 20, 2016

Hello @mayukojpn, thank you very much for your contribution.

We will check the issue #31 and this pull request as well.

@guzzilar

This comment has been minimized.

Copy link
Collaborator

guzzilar commented Apr 18, 2017

Hi @mayukojpn

Thanks for your contribution again.
(and sorry for leaving this issue here for couple months).

I am going to merge this PR now, also, will continue on Replace Omise_Util::translate with native gettext. task that you mentioned on ticket #31

👍 appreciated.
Nam

@guzzilar guzzilar merged commit f27ec08 into omise:develop Apr 18, 2017
1 check failed
1 check failed
ci/circleci No test commands were found
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.