Add Omise Setting page (separate between general settings and payment method settings) #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? Because previously, these configs were located under the 'WooCommerce > Checkout > Omise Credit / Debit Card' page, which is in fact, these configs will be used for other payment methods as well. Without having its own separated page could confusing user on the setting (i.e. user sets pkey/skey at Credit Card payment method but can also use for IB and Alipay). Also, Webhook feature is coming. Means we need to have some place to have a webhook url setting and it shouldn't be 'WooCommerce > Checkout > Omise Credit / Debit Card' nor other payment method pages.
…it Card' setting page. For the reason, please read the previous commit message.
guzzilar
force-pushed
the
setting-page
branch
from
4334bd9
to
8f1bba5
Compare
guzzilar
force-pushed
the
setting-page
branch
from
8f1bba5
to
bacb243
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Previously, Omise configs were located under the
WooCommerce > Checkout > Omise Credit / Debit Cardpage, which is in fact, these configs will be used for other payment methods as well.Without having its own separated page could confusing user on the setting (i.e. user sets pkey/skey at Credit Card payment method but can also use for IB and Alipay).
Also, Webhook feature is coming. Means we need to have some place to have a webhook url setting and it shouldn't be under the
WooCommerce > Checkout > Omise Credit / Debit Cardor other payment method pages.Related information:
Related issue(s): 🙅
2. Description of change
Setting page under the Omise menu at WordPress admin page.
Removed
Payment Settingssection fromWooCommerce > Checkout > Omise Credit / Debit Cardpage.3. Quality assurance
🔧 Environments:
✏️ Details:
Make sure that this implementation won't cause any trouble with the current settings that has been set at the previous setting page.
1.1 Assume that a user already installed Omise and config his public/ secret keys at his store (if not, then install Omise-WooComemrce v3.0 and setup first).
1.2. Deploy this PR.
1.3. Then go to Omise new setting page, your current settings should be displayed there properly.
Make sure that your store can perform checkout with credit card and other payment methods properly
2.1 Continue from [1]. Without any extra steps, your store should still work as normal.
Make sure that user can setup new Omise-WooCommerce plugin and able to config his Omise settings properly.
3.1 Assume that user just about to installs Omise for the first time (if not, then re-install WordPree & WooCommerce & Omise from scratch).
3.2 Test config public / secret keys and enable test mode.
3.3 Your config should be persisted there.
Make sure that you can use your keys from step [3] to make charge with any payment methods (Credit / Debit Card, Alipay, Internet Banking).
4. Impact of the change
No
5. Priority of change
Normal
6. Additional Notes
No