From ab0e1c1ec4e40e9500aee8e3a88b37f904669d2d Mon Sep 17 00:00:00 2001
From: Gerardo Nardelli <gerardo.nardelli@altoros.com>
Date: Thu, 1 Aug 2019 18:35:56 -0300
Subject: [PATCH] Minor fixes on contracts (#260)

* Remove unused SafeMath in BasicForeignBridge
* Add name to mint parameters for consistency in IBurnableMintableERC677Token
* Fix return comment in version method of UpgradeabilityStorage
---
 contracts/interfaces/IBurnableMintableERC677Token.sol  | 2 +-
 contracts/upgradeability/UpgradeabilityStorage.sol     | 2 +-
 contracts/upgradeable_contracts/BasicForeignBridge.sol | 2 --
 3 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/contracts/interfaces/IBurnableMintableERC677Token.sol b/contracts/interfaces/IBurnableMintableERC677Token.sol
index 31cfba6a..f244abc9 100644
--- a/contracts/interfaces/IBurnableMintableERC677Token.sol
+++ b/contracts/interfaces/IBurnableMintableERC677Token.sol
@@ -2,7 +2,7 @@ pragma solidity 0.4.24;
 import "../interfaces/ERC677.sol";
 
 contract IBurnableMintableERC677Token is ERC677 {
-    function mint(address, uint256) public returns (bool);
+    function mint(address _to, uint256 _amount) public returns (bool);
     function burn(uint256 _value) public;
     function claimTokens(address _token, address _to) public;
 }
diff --git a/contracts/upgradeability/UpgradeabilityStorage.sol b/contracts/upgradeability/UpgradeabilityStorage.sol
index d31f8667..6964127a 100644
--- a/contracts/upgradeability/UpgradeabilityStorage.sol
+++ b/contracts/upgradeability/UpgradeabilityStorage.sol
@@ -13,7 +13,7 @@ contract UpgradeabilityStorage {
 
     /**
     * @dev Tells the version name of the current implementation
-    * @return string representing the name of the current version
+    * @return uint256 representing the name of the current version
     */
     function version() external view returns (uint256) {
         return _version;
diff --git a/contracts/upgradeable_contracts/BasicForeignBridge.sol b/contracts/upgradeable_contracts/BasicForeignBridge.sol
index 02f2689c..706fa300 100644
--- a/contracts/upgradeable_contracts/BasicForeignBridge.sol
+++ b/contracts/upgradeable_contracts/BasicForeignBridge.sol
@@ -1,14 +1,12 @@
 pragma solidity 0.4.24;
 
 import "../upgradeability/EternalStorage.sol";
-import "openzeppelin-solidity/contracts/math/SafeMath.sol";
 import "openzeppelin-solidity/contracts/token/ERC20/ERC20Basic.sol";
 import "./Validatable.sol";
 import "../libraries/Message.sol";
 import "./BasicBridge.sol";
 
 contract BasicForeignBridge is EternalStorage, Validatable, BasicBridge {
-    using SafeMath for uint256;
     /// triggered when relay of deposit from HomeBridge is complete
     event RelayedMessage(address recipient, uint256 value, bytes32 transactionHash);
     function executeSignatures(uint8[] vs, bytes32[] rs, bytes32[] ss, bytes message) external {