Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/auth hash credentials #178

Closed
wants to merge 9 commits into from
Closed

Feature/auth hash credentials #178

wants to merge 9 commits into from

Conversation

dnic
Copy link

@dnic dnic commented Sep 13, 2019

The Auth Hash Schema allows for optional credentials to be added to the Auth Hash. This PR is adding that functionality.

dnic and others added 4 commits September 12, 2019 12:53
Fixing spacing.
response as an attribute. The commented out code would try to dig the
response for the credentials to be anywhere, but for the D.O.E.'s
purposes, we're going to try leveraging the session index as an
effective access token in an authorization flow.
@coveralls
Copy link

coveralls commented Sep 25, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling aac9d34 on dnic:feature/auth_hash_credentials into a0eedd6 on omniauth:master.

Everything is moved into the credentials method, grabbing the session
index to act like an access token for validation. Expires time is first
grabbed from the authnstatement, then from the conditions.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants