Uncaught exception in Twitter strategy #158

Closed
arthuraa opened this Issue Jan 27, 2011 · 1 comment

2 participants

@arthuraa

I've experienced the following problem: a bad server response from Twitter returning an error HTML caused a MultiJson::DecodeError exception to be raised in OmniAuth::Strategies::Twitter#user_hash. The exception passed uncaught and caused a server error. Perhaps it would be good to catch that somewhere and call #fail! ?

@mbleigh

Catch JSON parsing errors in OAuth strategies. Closed by 99d0fad

@sergioazevedo sergioazevedo pushed a commit to intelie/omniauth that referenced this issue Jun 8, 2011
Michael Bleigh Catch JSON parsing errors in OAuth strategies. Closes #158 99d0fad
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment