Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make omniauth.auth a Mash in test mode as well #556

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants

piotrj commented Dec 16, 2011

Normally omniauth sets the omniauth.auth to be a subclass of Hashie::Mash. So if I rely on it having particular methods in my application code it breaks in integration tests if I use test mode.

@piotrj piotrj Make omniauth.auth a Mash in test mode as well
Normally omniauth sets the omniauth.auth to be a subclass of Hashie::Mash. So if I rely on it having particular methods in my application code it breaks in integration tests if I use test mode.
4b20993

@piotrj piotrj referenced this pull request Dec 19, 2011

Closed

'extra' method undefined #558

Contributor

mbleigh commented Jan 11, 2012

Closed by a later pull request, fixed in master.

@mbleigh mbleigh closed this Jan 11, 2012

novito commented Jun 9, 2012

Why is this one closed? If I follow this: https://github.com/intridea/omniauth/wiki/Integration-Testing -- And in my code I try to access as a Hashie, when running the tests it breaks because it doesn't know how to solve my_hash.key because it's a hash and not a Hashie.

piotrj commented Jun 10, 2012

This one is closed because the issue was solved by #564.
Which version are you using?

novito commented Jun 10, 2012

I am using omniauth-facebook (1.3.0), so I assume this is because i am not using omniauth gem itself.

piotrj commented Jun 11, 2012

You are using omniauth gem itself - omniauth-facebook has omniauth-oauth2 as dependency and omniauth-oauth2 has omniauth as dependency.

I will try to find some time later today and take a look at the version you are using and see what could be the problem.

novito commented Jun 11, 2012

I am going to be providing a gist so you can see what am I doing. Maybe the dependency with Omniauth is with a version that the test Hashie wasn't fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment