Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Refactor ssl check #664

Merged
merged 1 commit into from Feb 13, 2013

Conversation

Projects
None yet
2 participants
Contributor

aitor commented Feb 13, 2013

I've refactored the ssl check to mimic Rack::Request#ssl? behavior as stated in #663. I've removed the query = nil assigment too since it looked redundant just after the gsub and added a few test for a custom full_host that were not provided before.

Refactor ssl check to mimic Rack::Request#ssl? behavior as stated in #…
…663. I've removed the query assigment since it looked redundant just after the gsub and added a few test for a custom full_host that were not provided before.
Contributor

sferik commented Feb 13, 2013

This looks great. Thanks!

sferik added a commit that referenced this pull request Feb 13, 2013

@sferik sferik merged commit 5b30e8d into omniauth:master Feb 13, 2013

@aitor aitor deleted the aitor:improved_ssl_check branch Feb 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment