change readme instructions to use `get` in routes #678

Merged
merged 1 commit into from Apr 17, 2013

Conversation

Projects
None yet
3 participants
@hstove
Contributor

hstove commented Apr 16, 2013

Rails 4 deprecates match in routes, and this redirect will always be a get, so I think it would be helpful to start promoting this method.

change readme instructions to use `get` in routes
Rails 4 deprecates `match` in routes, and this redirect will always be a `get`, so I think it would be helpful to start promoting this method.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 16, 2013

Coverage Status

Coverage decreased (-12.61%) when pulling 037adc9 on hstove:patch-1 into fe14887 on intridea:master.

Coverage Status

Coverage decreased (-12.61%) when pulling 037adc9 on hstove:patch-1 into fe14887 on intridea:master.

sferik added a commit that referenced this pull request Apr 17, 2013

Merge pull request #678 from hstove/patch-1
change readme instructions to use `get` in routes

@sferik sferik merged commit 67af802 into omniauth:master Apr 17, 2013

1 check passed

default The Travis build passed
Details
@sferik

This comment has been minimized.

Show comment
Hide comment
@sferik

sferik Apr 17, 2013

Contributor

Thanks for the patch!

Contributor

sferik commented Apr 17, 2013

Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment