security issue in returning post parameters from session in callback phase #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping ? due to security concern |
|
I haven't been involved in this project in years and know nothing about this. |
|
@lalithr95 Thanks! |
stevendanna
added a commit
to chef/chef-server
that referenced
this pull request
Jan 18, 2017
Recently, omniauth shipped a fix to a security vulnerability: omniauth/omniauth#867 I haven't investigated whether this is a serious issue for us, but it seemed prudent to just try an update. Signed-off-by: Steven Danna <steve@chef.io>
robbkidd
added a commit
to chef/supermarket
that referenced
this pull request
Jan 18, 2017
Described in omniauth/omniauth#867 Signed-off-by: Robb Kidd <rkidd@chef.io>
marcparadise
pushed a commit
to chef/chef-server
that referenced
this pull request
Jan 20, 2017
Recently, omniauth shipped a fix to a security vulnerability: omniauth/omniauth#867 I haven't investigated whether this is a serious issue for us, but it seemed prudent to just try an update. Signed-off-by: Steven Danna <steve@chef.io>
|
This issue has been assigned CVE-2017-18076 by MITRE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request phase of omniauth store
request.paramsin session which are later assigned in env of callback phase. According do docs we should only store query params but in this case both GET and POST params get stored. POST params can containauthenticity_tokenof application to protect form CSRF issues. We shouldn't leak such tokens from POST params.@sferik @jamesarosen @md5