First draft of a finder implementation #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alilleybrinker
added
type: feature
alilleybrinker
commented
Jan 3, 2023
Member
Author
|
@nellshamrell what do you think? This involves changes to the trait bounds for |
Collaborator
|
This looks outstanding! Looks like there are some merge conflicts, just let me know when those are resolved. Since we are pre 1.0, I am fine with changing the trait bounds for |
This commits adds a new `Finder` struct which matches different sources of `GitOid`s against a known set of `GitOid`s, returning both an identifier and the matching `GitOid` itself, along with reporting any errors that arise when resolving the new `GitOid`s. The docs for the `Finder` struct spell it out the clearest. This design is centered around the new `IntoIdentifiedGitOid` trait, which is implemented for a variety of existing types. The goal of this is to allow the `Finder` to be generic over things which produce `GitOid`s, so that, for example, someone could add a mechanism to resolve `GitOid`s from a `Url` without changing any existing code. Signed-off-by: Andrew Lilley Brinker <alilleybrinker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds a new
Finderstruct which matches different sources ofGitOids against a known set ofGitOids, returning both an identifier and the matchingGitOiditself, along with reporting any errors that arise when resolving the newGitOids.The docs for the
Finderstruct spell it out the clearest. This design is centered around the newIntoIdentifiedGitOidtrait, which is implemented for a variety of existing types. The goal of this is to allow theFinderto be generic over things which produceGitOids, so that, for example, someone could add a mechanism to resolveGitOids from aUrlwithout changing any existing code.Signed-off-by: Andrew Lilley Brinker alilleybrinker@gmail.com