Initial steps toward making std an optional feature.
#81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of #20, we'd like to make `std` into an optional dependency for the `gitoid` crate, so it can be used in `no_std` environments. This requires both transitioning usage of dependencies to `no_std`, and moving our own imports away from `std`. As a first step, this commit transitions just the imports which are direct re-exports of things from `core`, to use the original `core` imports instead. We're not ready for `no_std` yet, but this does move us closer. Signed-off-by: Andrew Lilley Brinker <abrinker@mitre.org>
Per #20, we want to make `gitoid` `no_std`-compatible. Three of our deps: `hex`, `sha1`, and `sha2` are `no_std`-compatible. Of those, only `sha2` appears to be able to transition to turn off `std` immediately without impact to the APIs we use. For `hex` and `sha1`, we'll need to update our usage of the APIs to avoid the things that are turned off when the import becomes `no_std`. This commit doesn't undertake the work of actually transitioning the usage, but _does_ update the `Cargo.toml` file to: - Transition `sha2` to `no_std` immediately. - Update our import of `hex` and `sha1` to turn off default features and then purposefully activate the `std` feature. This makes the status of using `std` more clear, and paves for way for removing the manual activation in the future when we've updated our usage of those deps. Signed-off-by: Andrew Lilley Brinker <abrinker@mitre.org>
alilleybrinker
added
type: feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses part of #20.