Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript Definition - Added ActionCreators & ActionTypes (+ minor bug fixes) #134

Merged
merged 1 commit into from Nov 21, 2016

Conversation

@mcrawshaw
Copy link
Contributor

@mcrawshaw mcrawshaw commented Nov 14, 2016

This completes Typescript definitions for the API.

I have also moved the import out of global scope and removed a 'typeof' that was causing a compilation failure in the current Typescript version.

@forabi would you like to double check my work?

Mark Crawshaw
+ minor bug fixes
@mcrawshaw mcrawshaw changed the title Added ActionCreators & ActionTypes (+ minor bug fixes) Typescript Definition - Added ActionCreators & ActionTypes (+ minor bug fixes) Nov 14, 2016
@forabi
Copy link
Contributor

@forabi forabi commented Nov 14, 2016

Looks good to me! Thanks!

@mcrawshaw
Copy link
Contributor Author

@mcrawshaw mcrawshaw commented Nov 16, 2016

This is ready to go @omnidan. Not urgent.

@omnidan
Copy link
Owner

@omnidan omnidan commented Nov 21, 2016

Looks good, thanks a lot for working on typescript support 😁

@omnidan omnidan merged commit 8d55f72 into omnidan:master Nov 21, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@omnidan
Copy link
Owner

@omnidan omnidan commented Nov 21, 2016

released beta9-2 with this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants