Ajax.updateRow error in Primefaces datatable with paging #127

Closed
GithubJohn3031 opened this Issue Apr 30, 2015 · 2 comments

Projects

None yet

2 participants

@GithubJohn3031

Ajax.updateRow has problem with Primefaces datatable component, if paging is activated. The row will not be updated if it is on page with number >1. I reckon it is some problem with primefaces incompatibility get.Rows() and table.getRowCount() and standard JSF Table component.

Relevant code snippet from Omnifaces Ajax.updateRow():

int rowCount = (table.getRows() == 0) ? table.getRowCount() : table.getRows();
if (index >= rowCount) {
  return;
}

We fixed it locally (comment out this code part), but it would be cool to fix it for future Omnifaces versions.
As far as I know Primefaces 5.2 has this feauture already and permits to update the specific row.

@BalusC
Member
BalusC commented Apr 30, 2015

Makes sense.

@BalusC BalusC added a commit that closed this issue Jul 14, 2015
@BalusC BalusC Fix #127: Don't consider table.getRows in Ajax#updateRow() so paginated
tables are also supported.
bf52de2
@BalusC BalusC closed this in bf52de2 Jul 14, 2015
@BalusC
Member
BalusC commented Jul 14, 2015

Fix is present in today's 2.2 snapshot. Thank you for reporting!

@BalusC BalusC added the bug label Oct 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment