New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajax.updateRow error in Primefaces datatable with paging #127

Closed
GithubJohn3031 opened this Issue Apr 30, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@GithubJohn3031

GithubJohn3031 commented Apr 30, 2015

Ajax.updateRow has problem with Primefaces datatable component, if paging is activated. The row will not be updated if it is on page with number >1. I reckon it is some problem with primefaces incompatibility get.Rows() and table.getRowCount() and standard JSF Table component.

Relevant code snippet from Omnifaces Ajax.updateRow():

int rowCount = (table.getRows() == 0) ? table.getRowCount() : table.getRows();
if (index >= rowCount) {
  return;
}

We fixed it locally (comment out this code part), but it would be cool to fix it for future Omnifaces versions.
As far as I know Primefaces 5.2 has this feauture already and permits to update the specific row.

@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC Apr 30, 2015

Member

Makes sense.

Member

BalusC commented Apr 30, 2015

Makes sense.

@BalusC BalusC closed this in bf52de2 Jul 14, 2015

@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC Jul 14, 2015

Member

Fix is present in today's 2.2 snapshot. Thank you for reporting!

Member

BalusC commented Jul 14, 2015

Fix is present in today's 2.2 snapshot. Thank you for reporting!

@BalusC BalusC added the bug label Oct 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment