New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported constants not accessible during postback with disabled partial state saving #250

Closed
VsevolodGolovanov opened this Issue May 18, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@VsevolodGolovanov

VsevolodGolovanov commented May 18, 2016

See reproducer.
The same code works fine with OF2.0 or with enabled partial state saving.

@VsevolodGolovanov

This comment has been minimized.

Show comment
Hide comment
@VsevolodGolovanov

VsevolodGolovanov May 18, 2016

Probably caused by the Issue #98 fix.
Update: actually rolling back the fix doesn't help.
Fully reverting ImportConstants.java to its 2.0 state does fix the issue.

VsevolodGolovanov commented May 18, 2016

Probably caused by the Issue #98 fix.
Update: actually rolling back the fix doesn't help.
Fully reverting ImportConstants.java to its 2.0 state does fix the issue.

@BalusC BalusC closed this in ce5a965 May 21, 2016

@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC May 21, 2016

Member

Can't reproduce #98 anymore with current Mojarra 2.2.13. I've rolled back it (alternative fix was to put in view scope instead of request scope, but this feels wrong). Fix is available in today's 2.4 snapshot. Thank you for reporting and improving OmniFaces!

Member

BalusC commented May 21, 2016

Can't reproduce #98 anymore with current Mojarra 2.2.13. I've rolled back it (alternative fix was to put in view scope instead of request scope, but this feels wrong). Fix is available in today's 2.4 snapshot. Thank you for reporting and improving OmniFaces!

@VsevolodGolovanov

This comment has been minimized.

Show comment
Hide comment
@VsevolodGolovanov

VsevolodGolovanov May 24, 2016

It is fixed, not sure why I thought that rolling back the 98 fix doesn't help.
Maybe forgot to actually build the library when checking or something.

VsevolodGolovanov commented May 24, 2016

It is fixed, not sure why I thought that rolling back the 98 fix doesn't help.
Maybe forgot to actually build the library when checking or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment