New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numbers#formatThousandsUnit does not format with maxfractions if number < base #251

Closed
jepsar opened this Issue May 18, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@jepsar

jepsar commented May 18, 2016

of:formatThousandsUnit('2.3333333333333','W') ends up as 2.3333333333333 W, while 2.33 Wis expected.

@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC May 21, 2016

Member

Fixed along with #252

Member

BalusC commented May 21, 2016

Fixed along with #252

@BalusC BalusC closed this May 21, 2016

@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC May 21, 2016

Member

Initially, values lower than 1000 are unaffected, as documented. I however agree that this is not nice. Now values lower than 1000 are formatted too, including 999.999 which becomes 1k. Improvement is available in today's 2.4 snapshot. Thank you for reporting and improving OmniFaces!

Member

BalusC commented May 21, 2016

Initially, values lower than 1000 are unaffected, as documented. I however agree that this is not nice. Now values lower than 1000 are formatted too, including 999.999 which becomes 1k. Improvement is available in today's 2.4 snapshot. Thank you for reporting and improving OmniFaces!

@jepsar

This comment has been minimized.

Show comment
Hide comment
@jepsar

jepsar May 23, 2016

Yeah, the original code was designed to handle bytes (integers), that's probably how this must have slipped in. Thanks for fixing!

jepsar commented May 23, 2016

Yeah, the original code was designed to handle bytes (integers), that's probably how this must have slipped in. Thanks for fixing!

@jepsar jepsar changed the title from Numbers#formatThousandsUnit does not formats with maxfractions if number < base to Numbers#formatThousandsUnit does not format with maxfractions if number < base May 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment