New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fine grained logging level in FullAjaxExceptionHandler #258

Closed
pvdlg opened this Issue Jun 2, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@pvdlg
Contributor

pvdlg commented Jun 2, 2016

FullAjaxExceptionHandler always log with the method logException. It can be overwritten to change the log level, however it's not possible to set a different log level based on the cause of the error.

L401 and L438 are "unexpected" error, in the sense that throwing an Exception after the response is commited or attempting to display an error page containing errors is a programation error. Therefore these cases make sense to be logged with the SEVERE level.

Although L392 and L396 are "expected" errors in the sense that the exception handler performed as expected by redirecting to a working error page.

Ideally we should keep logging L401 and L438 as SEVERE and allow to choose the log level for L392 and L396, either by overriding logException or with a Web.xml parameter.

@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC Jun 2, 2016

Member

Makes sense.

Member

BalusC commented Jun 2, 2016

Makes sense.

@BalusC BalusC closed this in 277dc15 Jun 2, 2016

@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC Jun 2, 2016

Member

I added a protected enum LogReason indicating the log reason and a new logException() overload where this is passed. It's available in today's 2.4-SNAPSHOT.

Thank you for improving OmniFaces!

Member

BalusC commented Jun 2, 2016

I added a protected enum LogReason indicating the log reason and a new logException() overload where this is passed. It's available in today's 2.4-SNAPSHOT.

Thank you for improving OmniFaces!

@pvdlg

This comment has been minimized.

Show comment
Hide comment
@pvdlg

pvdlg Jun 2, 2016

Contributor

Thanks !

Contributor

pvdlg commented Jun 2, 2016

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment