New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always make server-created cookies HttpOnly #272

Closed
BalusC opened this Issue Jun 21, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@BalusC
Member

BalusC commented Jun 21, 2016

#232

It's considered bad practice when server-created cookies are modifiable in JavaScript. Instead, such cookies must be created by JavaScript itself.

Ideally, all server-created cookies must be HttpOnly, without exceptions. Currently, Faces, FacesLocal and Servlets utility classes doesn't take into account this.

@BalusC BalusC changed the title from Always make cookies HttpOnly to Always make server-created cookies HttpOnly Jun 21, 2016

@pvdlg

This comment has been minimized.

Show comment
Hide comment
@pvdlg

pvdlg Jun 22, 2016

Contributor

Updated #232 per recommendations in the PR comments.

Contributor

pvdlg commented Jun 22, 2016

Updated #232 per recommendations in the PR comments.

@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC Jun 22, 2016

Member

As this is a potentially breaking change, I will implement it once 2.4 has been released and branch is ready for 2.5.

Member

BalusC commented Jun 22, 2016

As this is a potentially breaking change, I will implement it once 2.4 has been released and branch is ready for 2.5.

@BalusC BalusC closed this in a4234ef Jul 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment