New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap IOException over all place in Faces/FacesLocal in UncheckedIOException #338

Closed
BalusC opened this Issue Jan 10, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@BalusC
Member

BalusC commented Jan 10, 2017

All IOExceptions thrown by Faces/FacesLocal are those which you can't do anything about. Redeclaring throws IOException in every method is annoying. When doing so in @PostConstruct, CDI also starts to warn that this isn't conform spec.

Solution is to let Faces/FacesLocal rethrow them as UncheckedIOException. It shouldn't make much difference for the client anyway as all of those IOExceptions already happen to indicate a problem with delivering the response to the client.

As this is a breaking change, better not do it before OmniFaces 3.0.

@BalusC BalusC changed the title from Consider wrapping IOException over all place in Faces/FacesLocal in a FacesException to Wrapping IOException over all place in Faces/FacesLocal in UncheckedIOException Feb 13, 2017

@BalusC BalusC changed the title from Wrapping IOException over all place in Faces/FacesLocal in UncheckedIOException to Wrap IOException over all place in Faces/FacesLocal in UncheckedIOException Feb 13, 2017

@BalusC BalusC closed this in da4cec6 May 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment