Bug with o:validateBean and composite components #342

Closed
recentralized opened this Issue Jan 21, 2017 · 1 comment

Projects

None yet

2 participants

@recentralized
Contributor

Hi Bauke, I've opened pull request #341 which solves a problem with o:validateBean when it's value attribute references a composite component attribute, e.g.:

<o:validateBean value="#{cc.attrs.controller.entity}" .../>

Within the ValidateBean tag handler, the ValueExpression evaluation returns null, then ValidateBean continues down a path as if the value attribute was never specified.

My limited understanding is that UIComponent "visitation" needs to happen in order to resolve #{cc...} expressions.

@recentralized recentralized changed the title from Bug with o:validateBean and composite compoonents to Bug with o:validateBean and composite components Jan 21, 2017
@BalusC BalusC closed this in 5f3ec34 Jan 21, 2017
@BalusC
Member
BalusC commented Jan 21, 2017 edited

It's available in today's 2.6-SNAPSHOT. I will extend the ValidateBeanIT on this later.

@BalusC BalusC added a commit that referenced this issue Jan 21, 2017
@BalusC BalusC #342 Fix javadoc error 5b399c4
@BalusC BalusC added a commit that referenced this issue Jan 21, 2017
@BalusC BalusC #342: Fix Sonar warnings 10d2d82
@BalusC BalusC added a commit that referenced this issue Jan 22, 2017
@BalusC BalusC #342: further improved showMessageFor=@violating so it also works when
using method="copiedBean"
2509844
@BalusC BalusC added a commit that referenced this issue Jan 22, 2017
@BalusC BalusC #342 Fixed Sonar warnings 3a409e0
@recentralized recentralized added a commit to recentralized/omnifaces-omnifaces that referenced this issue Jan 27, 2017
@recentralized recentralized Reopened and fixed issue #342: Previous fix <o:validateBean value="#{…
…cc.attrs.controller.entity}" .../> within composite components only solved the case where the including page declared the h:form, however if the composite component itself declares the h:form then ValueExpression will still be evaluated as null
1bc976e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment