Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Nested forms check fails with <p:dialog appendTo="@(body)"> #349
I have a problem regarding the #181 nested form check.
Error in Development:
Note: Without the p:dialog attribute dynamic="true", the inner form is rendered as:
The form component is not present explicitly. The nested form check still fails.
Very best and thanks in advance,
Not directly technical. But our application is component based and some components do have dialogs inside.
For instance, we have different picker components to open a dialog in order to pick one out of multiple values.
By clicking at the zoom button a dialog shows a list of charges. The whole component can be parameterized to filter values beforehand. A listener is used to get the current selected item.
In general, we include multiple components:
my:componentX defined as:
However, we are using this kind of components throughout our whole application. We didn't see any problem so far, since all p:dialogs are appended directly to the body.
Thank you for your fast answer and your fix. It works perfectly!
Nevertheless, I checked meanwhile all our forms and dialogs manually and found one case where we did not follow the nested form constraint and used two nested forms in ONE dialog.
It might make sense to switch back to your first commit and fix it with:
or include another form in between check.
But that is only an additional hint. Again thank you for seeing the need to fix it!
Sorry to say: The latest fix does not work for us. Sometimes a component uses another component.
The second fix forbids:
which is indeed - considering dialogs are appended to body - correct.