New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PrimeFaces 'partial submit' to generic JSF #394

Closed
kukel opened this Issue Jul 28, 2017 · 12 comments

Comments

Projects
None yet
5 participants
@kukel

kukel commented Jul 28, 2017

PrimeFaces has the partialSubmit feature which reduces network traffic and some (small) processing time on the server. Maybe it is an option to add some generic feature that, for both Mojarra and MyFaces, strips the ajax request from not-exectuted fields to also reduce the network traffic. Something like

<o:form partialSubmit="true">

I did not experiment yet if this is possible since I'm not to familiar with the javascript ajax feature of the core jsf implementations due to the fact that I use PrimeFaces. So it might not even be possible. Just thought of filing the issue See next comment

See this stackoverflow question

@kukel

This comment has been minimized.

Show comment
Hide comment
@kukel

kukel Jul 30, 2017

I got a basic example working on Mojarra 2.2.8. It is added as an answer to the Stackoverflow question

kukel commented Jul 30, 2017

I got a basic example working on Mojarra 2.2.8. It is added as an answer to the Stackoverflow question

@arjantijms

This comment has been minimized.

Show comment
Hide comment
@arjantijms

arjantijms Jul 30, 2017

Member

This was one of the things we really wanted to get in JSF 2.3 as well, but it unfortunately (again) didn't happen. Still surprised this wasn't done right from the beginning in 2.0.

Member

arjantijms commented Jul 30, 2017

This was one of the things we really wanted to get in JSF 2.3 as well, but it unfortunately (again) didn't happen. Still surprised this wasn't done right from the beginning in 2.0.

@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC Jul 30, 2017

Member

Nice solution. Looks like it should work on MyFaces as well.

Member

BalusC commented Jul 30, 2017

Nice solution. Looks like it should work on MyFaces as well.

@BalusC BalusC closed this in 23d5fd2 Aug 1, 2017

@kukel

This comment has been minimized.

Show comment
Hide comment
@kukel

kukel Aug 1, 2017

Great, thanks (on behalf of everyone else) Small nitpick: no label/milestone added to the issue?

kukel commented Aug 1, 2017

Great, thanks (on behalf of everyone else) Small nitpick: no label/milestone added to the issue?

@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC Aug 2, 2017

Member

Only if it can be automated.

Member

BalusC commented Aug 2, 2017

Only if it can be automated.

@kukel

This comment has been minimized.

Show comment
Hide comment
@kukel

kukel Aug 2, 2017

or delegated? ;-)

kukel commented Aug 2, 2017

or delegated? ;-)

@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC Aug 2, 2017

Member

Are you volunteering?

Member

BalusC commented Aug 2, 2017

Are you volunteering?

BalusC added a commit that referenced this issue Aug 2, 2017

#394: improved partialSubmit="false" check; replaced this by jsf as this
will fail when script is executed as part of partial response
@plasmabot

This comment has been minimized.

Show comment
Hide comment
@plasmabot

plasmabot Sep 20, 2017

hi omnifaces experts,
is this fix already available in maven?

plasmabot commented Sep 20, 2017

hi omnifaces experts,
is this fix already available in maven?

@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC Sep 20, 2017

Member

It's in 3.0-SNAPSHOT.

Member

BalusC commented Sep 20, 2017

It's in 3.0-SNAPSHOT.

@kukel

This comment has been minimized.

Show comment
Hide comment
@kukel

kukel Nov 20, 2017

Are you volunteering?

Why not... (sorry I missed this). What would it all be about?

kukel commented Nov 20, 2017

Are you volunteering?

Why not... (sorry I missed this). What would it all be about?

@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC Nov 20, 2017

Member

Adding labels/milestones to issues :P

Member

BalusC commented Nov 20, 2017

Adding labels/milestones to issues :P

@Rapster

This comment has been minimized.

Show comment
Hide comment
@Rapster

Rapster Mar 10, 2018

Hi BalusC,

I've never had the opportunity to thank you for the great work you're bringing to the JSF community, so there it is, a big thank you! 😉

Regarding this feature, is it possible to post an example to see the real difference with and without partialSubmit?

Rapster commented Mar 10, 2018

Hi BalusC,

I've never had the opportunity to thank you for the great work you're bringing to the JSF community, so there it is, a big thank you! 😉

Regarding this feature, is it possible to post an example to see the real difference with and without partialSubmit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment