New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FullAjaxExceptionHandler does not removes the exception from queue when 'shouldHandleExceptionRootCause' returns false #417

Closed
vijpan opened this Issue Nov 15, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@vijpan

vijpan commented Nov 15, 2017

Env: Liberty App Server 17.0.0.2 (JEE 7 compliant - MyFaces JSF 2.2 implementation), Primefaces 6.1, Omnifaces 2.6.6, Java 8
Alias: PrimeFaces - PF

FullAjaxExceptionHandler - Looks like this commit referred in this stackoverflow question related to the removal of exception from the queue was reverted in this recent commit

This creates a problem as the wrapped handler (MyFaces internal handler) will find the exception in the queue and will navigate to error page (if available) and the navigation(any other specific page or stay on same page) which might have happened in 'shouldHandleExceptionRootCause' will be lost.

Should not the exception also be removed from the queue when 'shouldHandleExceptionRootCause' returns false.

What do you think?
Thanks

@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC Nov 21, 2017

Member

That was unintended. I have fixed it.

Member

BalusC commented Nov 21, 2017

That was unintended. I have fixed it.

@BalusC BalusC closed this Nov 21, 2017

@vijpan

This comment has been minimized.

Show comment
Hide comment
@vijpan

vijpan Nov 21, 2017

Great. Thanks!

vijpan commented Nov 21, 2017

Great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment