New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content-Disposition with semicolon or double quote in name #423

Closed
melloware opened this Issue Dec 4, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@melloware

melloware commented Dec 4, 2017

Looking at your code here: https://github.com/omnifaces/omnifaces/blob/develop/src/main/java/org/omnifaces/util/Servlets.java#L405

It doesn't appear you handle semicolon or double quotes in file names which are valid in Unix. We have the same issue in PF and just thought I would report it here as well.

primefaces/primefaces#3034

BalusC added a commit that referenced this issue Dec 9, 2017

#423: improve content disposition filename parsing to take into account
nested quotes and semicolons; took opportunity to support filename* as
well

@BalusC BalusC closed this Dec 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment