New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Myfaces 2.3.1 and omnifaces 3.1 minor bug #464

Closed
cocorossello opened this Issue May 9, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@cocorossello

cocorossello commented May 9, 2018

Hi,

There is a minor error with myfaces 2.3.1 and CombinedResourceHandler. I'm not sure if it's myfaces error or omnifaces.

I have in my configuration (or in web.xml, it doesn't matter):
servletContextEvent.getServletContext().setInitParameter("org.omnifaces.COMBINED_RESOURCE_HANDLER_DISABLED", "true");

Then CombinedResourceHandler fails with:
java.lang.ClassCastException: java.base/java.lang.String cannot be cast to [C

The problem is in CombinedResourceHandler:309:
String.valueOf(evaluateExpressionGet(disabledParam)))

If it's changed to:
evaluateExpressionGet(disabledParam).toString())

it works (but it also should take care of null).

Workaround is as simple as use some dynamic property or subclass the CombinedResource class
servletContextEvent.getServletContext().setInitParameter("org.omnifaces.COMBINED_RESOURCE_HANDLER_DISABLED", "#{myBean.shouldDisableCominer}");

@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC May 15, 2018

Member

Fixed in 2.7-SNAPSHOT and 3.2-SNAPSHOT

Member

BalusC commented May 15, 2018

Fixed in 2.7-SNAPSHOT and 3.2-SNAPSHOT

@BalusC BalusC closed this May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment