New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logException() method not invoked in FullAjaxExceptionHandler if request wasn't ajax #477

Closed
crick77 opened this Issue Jul 27, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@crick77

crick77 commented Jul 27, 2018

As suggested by BalusC in StackOverflow question #51553394 the logException() method could be called even if the request was not ajax.
Maybe adding a context parameter to control this functionality and thus not breaking or having unwanted behaviour on existing code (if apply).

BalusC added a commit that referenced this issue Jul 28, 2018

#477: include UUID and IP in exception logging, and let
FacesExceptionFilter log exceptions as well.
@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC Jul 28, 2018

Member

After all, it's really better to handle these by a servlet filter so that exceptions during non-JSF requests are also covered.

The common requirement to include an UUID (and IP) in the log message (and request attribute) is however understood. I've taken the opportunity to improve both the FullAjaxExceptionHandler and FacesExceptionFilter on this. From version 3.2 on, they will both log an UUID and IP address, and the UUID will be available in error page by #{requestScope['org.omnifaces.exception_uuid']}.

Member

BalusC commented Jul 28, 2018

After all, it's really better to handle these by a servlet filter so that exceptions during non-JSF requests are also covered.

The common requirement to include an UUID (and IP) in the log message (and request attribute) is however understood. I've taken the opportunity to improve both the FullAjaxExceptionHandler and FacesExceptionFilter on this. From version 3.2 on, they will both log an UUID and IP address, and the UUID will be available in error page by #{requestScope['org.omnifaces.exception_uuid']}.

@BalusC BalusC closed this Jul 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment