Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE-8769] Basic caching of Promises returned by queryAsync #155

Open
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@jrajav
Copy link
Contributor

commented Jun 24, 2019

Cache queryAsync results while they are in flight only (transient mode), returning the same Promise to any callers requesting the same query string.

Also add a setter to turn transient mode off, caching results indefinitely until it is turned back on.

@bmatcuk
Copy link

left a comment

Looks like a good idea, and a decent implementation to me =)

Show resolved Hide resolved src/mapd-con-es6.js Outdated

@jrajav jrajav force-pushed the jrajav/queryAsync-cache branch from 5e74c87 to a6ad02c Jul 12, 2019

jrajav added some commits Jul 12, 2019

Bring in 'clone' module and add clonePromise method, so code mutating…
… the returned results objects doesn't affect anything else
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.