Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[FE-7442] Sql group by having support #68
Done code Formatting
Please note the test are failing - TypeError: Cannot read property 'is_array' of undefined
I have rewritten getProjectOn method in group -> writeQuery method.
The issue was that in getProjectOn the unnest is concatenated if row index in dimArray matches with metadata row index order, which I see is ideal scenario Since I can add dimensions in any order to the crossfilter and it is by chance that my order of adding dimension column will match it in metadata row order if u can see cf.getColumns() rows sequence
@sachinkaushikHERE I'm not sure how you did the code formatting, but can you try to match existing code formatting (that is, not change any lines not relevant to the actual changes)? Apologies that we don't have a canonical linter in this repo yet to make this simpler.
Also, having looked at the original ticket now, another request: Please add a unit test that generates an example query that is incorrect prior to this fix (for HAVING / ILIKE over array columns), but passes and generates the right query after it.